Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt)!: only add $f fetch prefix to auto-keys #8852

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 9, 2022

πŸ”— Linked issue

resolves nuxt/nuxt#15337

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's tricky to use refreshNuxtData to refresh a useFetch with an explicit key as there is currently an undocumented $f prefix added. I think we can choose only to add this prefix with an auto-key, meaning that users can manually invalidate the key more easily.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Nov 9, 2022
@danielroe danielroe requested a review from pi0 November 9, 2022 13:04
@danielroe danielroe self-assigned this Nov 9, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 9, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 9, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 535da43
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636bab6278583c000886c65f

@pi0 pi0 merged commit 1709934 into main Nov 10, 2022
@pi0 pi0 deleted the fix/fetch-prefix branch November 10, 2022 08:39
@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clearNuxtData does not work with useFetch and a provided key
2 participants