Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-app): move head to index to avoid global state #6807

Merged
merged 1 commit into from
Dec 18, 2019
Merged

fix(vue-app): move head to index to avoid global state #6807

merged 1 commit into from
Dec 18, 2019

Conversation

atinux
Copy link
Member

@atinux atinux commented Dec 18, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #6786

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@atinux atinux mentioned this pull request Dec 18, 2019
Closed
@atinux atinux requested a review from pi0 December 18, 2019 10:36
@atinux atinux changed the title fix: move head to index to avoid global state fix(vue-app): move head to index to avoid global state Dec 18, 2019
@pi0 pi0 merged commit 0cb2df7 into dev Dec 18, 2019
@pi0 pi0 deleted the fix-global-head branch December 18, 2019 14:27
@pi0 pi0 mentioned this pull request Feb 25, 2020
Merged
@pi0 pi0 mentioned this pull request Mar 3, 2020
Closed
This was referenced Mar 20, 2020
Merged
Open
This was referenced Mar 28, 2020
Merged
Merged
This was referenced Apr 8, 2020
Closed
Closed
Closed
Open
Merged
Open
Open
Open
Open
@pi0 pi0 mentioned this pull request Sep 1, 2020
Closed
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding content to head programmatically leads to duplicates after each request
3 participants
@atinux @pi0 @danielroe