Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Popover/Dropdown): prevent unintended closure on touchstart in mobile devices #1609

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix(Popover/Dropdown): prevent unintended closure on touchstart in mobile devices #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b9d06d
fix(Popover): Prevent immediate popover closure on touch start in mob…
vahid-bagheri Apr 3, 2024
45c7109
fix(Dropdown): Prevent immediate dropdown closure on touch start in m…
vahid-bagheri Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/runtime/components/elements/Dropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ export default defineComponent({
}
})

function onTouchStart () {
if (!menuApi.value) {
function onTouchStart (event: TouchEvent) {
if (!event.cancelable || !menuApi.value) {
return
}

Expand Down
4 changes: 2 additions & 2 deletions src/runtime/components/overlays/Popover.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ export default defineComponent({
}
})

function onTouchStart () {
if (!popoverApi.value) {
function onTouchStart (event: TouchEvent) {
if (!event.cancelable || !popoverApi.value) {
return
}

Expand Down
Loading