Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Rating): new component #513

Closed
wants to merge 128 commits into from
Closed

feat(Rating): new component #513

wants to merge 128 commits into from

Conversation

larrasu
Copy link
Contributor

@larrasu larrasu commented Aug 8, 2023

Resolves #505

  • Works with the Form component

Form validation looks a bit ugly since you cannot add borders or rings around the rating icons. drop-shadow class of Tailwind doesn't support other colors.

Any help is appreciated.

benjamincanac and others added 28 commits August 1, 2023 15:05
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Class priority issues in some cases when ring already defined on dark mode for example (input).
@stackblitz
Copy link

stackblitz bot commented Aug 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio
Copy link

nuxt-studio bot commented Aug 8, 2023

Live Preview ready!

Name Edit Preview Latest Commit
ui Edit on Studio ↗︎ View Live Preview 5ae6d55

@Haythamasalama
Copy link
Contributor

I solved the conflicts and refactored it, but still need to review and check all functionality @larrasu?

@larrasu
Copy link
Contributor Author

larrasu commented Oct 5, 2023

I solved the conflicts and refactored it, but still need to review and check all functionality @larrasu?

Hover styles are not working for some reason.
Thank you for updating this by the way!

EDIT: All fixed now.

@Haythamasalama
Copy link
Contributor

Haythamasalama commented Oct 5, 2023

I have made some updates to add the disabled prop and added a type for the size and update docs. Let me what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Rating