Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use token consistently throughout post #1237

Merged
merged 6 commits into from
Mar 14, 2021
Merged

docs: use token consistently throughout post #1237

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9aafc91
Fix wrong variable name
suruaku Feb 8, 2021
d967fc9
Merge pull request #1 from suruaku/suruaku-patch-1
suruaku Feb 8, 2021
a43bfe4
Update creating-a-nuxt-module.md
suruaku Feb 11, 2021
9d646a1
Update creating-a-nuxt-module.md
suruaku Feb 18, 2021
8666064
Merge branch 'main' into master
danielroe Mar 14, 2021
b51622f
Merge branch 'main' into master
danielroe Mar 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions content/en/blog/creating-a-nuxt-module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ export default function () {
}
```

We can then await the ngrok authtoken passing in the value of `token`which we have defined above.
We can then await the ngrok authtoken passing in the value of `authtoken`which we have defined above.
danielroe marked this conversation as resolved.
Show resolved Hide resolved

```js{}[modules/ngrok/index.js]
import ngrok from 'ngrok'
Expand All @@ -229,13 +229,13 @@ export default function () {

// Read ngrok property defined in nuxt.config.js
const options = nuxt.options.ngrok || {}
const token = process.env.NGROK_TOKEN || options.authtoken
const authtoken = process.env.NGROK_TOKEN || options.authtoken

// https://nuxtjs.org/docs/2.x/internals-glossary/internals-nuxt#hooks
nuxt.hook('listen', async function (server, { port }) {

if(options.authtoken){
await ngrok.authtoken(options.authtoken)
if(authtoken){
await ngrok.authtoken(authtoken)
}

url = await ngrok.connect(port)
Expand Down Expand Up @@ -265,8 +265,8 @@ export default function () {
// https://nuxtjs.org/docs/2.x/internals-glossary/internals-nuxt#hooks
nuxt.hook('listen', async function (server, { port }) {

if(options.authtoken){
await ngrok.authtoken(options.authtoken)
if(authtoken){
await ngrok.authtoken(authtoken)
}

url = await ngrok.connect(port)
Expand Down Expand Up @@ -384,13 +384,13 @@ export default function () {

// Read ngrok property defined in nuxt.config.js
const options = nuxt.options.ngrok || {}
const authtoken = process.env.NGROK_TOKEN
const authtoken = process.env.NGROK_TOKEN || options.authtoken

// https://nuxtjs.org/docs/2.x/internals-glossary/internals-nuxt#hooks
nuxt.hook('listen', async function (server, { port }) {

if(options.authtoken){
await ngrok.authtoken(options.authtoken)
if(authtoken){
await ngrok.authtoken(authtoken)
}


Expand Down