Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ja): translate guides/features/configuration #755

Merged
merged 5 commits into from
Oct 21, 2020
Merged

docs(ja): translate guides/features/configuration #755

merged 5 commits into from
Oct 21, 2020

Conversation

momokichi
Copy link
Contributor

aytdm
aytdm reviewed Oct 4, 2020
View reviewed changes
Copy link
Contributor

@aytdm aytdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！コメントしました
かっこの全角についてがほとんどで後は問題なさそうです（残りは明日以降で返していきます:pray:）

content/ja/guides/features/configuration.md Outdated Show resolved Hide resolved
content/ja/guides/features/configuration.md Outdated Show resolved Hide resolved
content/ja/guides/features/configuration.md Outdated Show resolved Hide resolved
content/ja/guides/features/configuration.md Outdated Show resolved Hide resolved
content/ja/guides/features/configuration.md Outdated Show resolved Hide resolved
@aytdm aytdm mentioned this pull request Oct 4, 2020
Closed
8 tasks
@momokichi
Copy link
Contributor Author

@aytdm
レビューありがとうございます。修正したのでお手すきの際に確認をお願いします 🙏

aytdm
aytdm approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@aytdm aytdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます。LGTM 🎉

@debs-obrien We're ready to merge. Thank you as always

@debs-obrien
Copy link
Contributor

@aytdm we are trying out code owners and gave you write access to the ja folder. You might have received an email. Can you please test it and see if you can merge. Let me know. Thanks

@inouetakuya inouetakuya mentioned this pull request Oct 20, 2020
Merged
@aytdm aytdm requested a review from inouetakuya as a code owner October 21, 2020 11:34
@aytdm
Copy link
Contributor

aytdm commented Oct 21, 2020

@debs-obrien @pi0 The merge button is now displayed. Thank you for your support.

@aytdm aytdm merged commit 3b12116 into nuxt:master Oct 21, 2020
@debs-obrien
Copy link
Contributor

fantastic. if you have any further issues then just let us know @aytdm

@aytdm aytdm mentioned this pull request Oct 25, 2020
Closed
93 tasks
pi0 pushed a commit that referenced this pull request Jul 8, 2021
@momokichi
docs(ja): translate guides/features/configuration (#755)
62908eb 
* add: configuration

* fix: fix configuration.md

* fix: replace '()' to '（）'

Co-authored-by: numa <aytdm@protonmail.com>
imgbot bot pushed a commit that referenced this pull request Jan 10, 2023
@momokichi @ImgBotApp
docs(ja): translate guides/features/configuration (#755)
20a1bce 
* add: configuration

* fix: fix configuration.md

* fix: replace '()' to '（）'

Co-authored-by: numa <aytdm@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aytdm aytdm aytdm approved these changes

@inouetakuya inouetakuya Awaiting requested review from inouetakuya

Assignees
No one assigned
Labels
japanese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@momokichi @debs-obrien @aytdm