Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an update-version.sh script and CI check to keep versions up to date #314

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

mdemoret-nv
Copy link
Contributor

This adds a new script ./ci/release/update-version.sh which will update all necessary versions used in the repo. This script should be run immediately after creating a new branch and tagging with the alpha tag.

This also runs the script in CI to ensure that no version is ever out of date.

@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change feature request New feature or request labels Apr 12, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner April 12, 2023 21:07
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #314 (9789611) into branch-23.07 (25d9ca8) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.07     #314      +/-   ##
================================================
+ Coverage         73.21%   73.24%   +0.03%     
================================================
  Files               390      390              
  Lines             13379    13379              
  Branches           1009     1009              
================================================
+ Hits               9795     9800       +5     
+ Misses             3584     3579       -5     
Flag Coverage Δ
cpp 69.08% <ø> (+0.04%) ⬆️
py 42.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d9ca8...9789611. Read the comment docs.

@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0d05cbf into nv-morpheus:branch-23.07 Apr 13, 2023
@mdemoret-nv mdemoret-nv deleted the mdd_update-versions branch April 13, 2023 16:25
rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Apr 13, 2023
… to date (#875)

This PR adds a new script `ci/release/update-version.sh` to help with updating the version numbers when making a new release. It also adds a CI check to ensure the versions are correct moving forward.

Note, these follow similar files in the RAPIDS org. For example, in cudf: https://github.com/rapidsai/cudf/blob/branch-23.06/ci/release/update-version.sh

Similar to MRC PR: nv-morpheus/MRC#314

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants