-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using cuda-toolkit
over cudatoolkit
#320
Switch to using cuda-toolkit
over cudatoolkit
#320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Morpheus is having issues when we just install cuda-toolkit, vs cudatookit, on some internal dgx machines, either because CMake isn't reliably finding all the installed headers/libraries, or because they're not being installed correctly.
These changes should probably be tested in a completely clean environment to make sure they work outside of dev/ci.
I think its the opposite, we're getting build issues when we install cudatookit, which are resolved by installing cuda-toolkit |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.07 #320 +/- ##
================================================
- Coverage 73.28% 73.27% -0.01%
================================================
Files 390 390
Lines 13382 13382
Branches 1010 1010
================================================
- Hits 9807 9806 -1
- Misses 3575 3576 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
My bad, I had it backwards :). Thanks David. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merging to test with Morpheus. May need updates |
/merge |
Description
This PR makes the following changes:
dev_env.yml
to installcuda-toolkit
overcudatoolkit
cudatoolkit=11.8
listed at the end. This is necessary to specify which version to use. Some packages still usecudatoolkit
and without specifying the version, 11.7 gets installed.meta.yml
to matchdev_env.yml
utilities
repo to no longer require Cython unless its usedChecklist