Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Revert partially constructed segments on-error in segment init function #361

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 2, 2023

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner August 2, 2023 18:30
@dagardner-nv dagardner-nv self-assigned this Aug 2, 2023
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change priority 1 labels Aug 2, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 2, 2023 18:43
rapids-bot bot pushed a commit that referenced this pull request Sep 6, 2023
Cherry picks some changes from #361 to allow other PRs to run CI since that PR is marked as `DO_NOT_MERGE`

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)
  - Christopher Harris (https://github.com/cwharris)

URL: #377
@dagardner-nv dagardner-nv requested a review from a team as a code owner September 26, 2023 15:05
@dagardner-nv dagardner-nv changed the title Revert partially constructed segments on-error in segment init function Draft: Revert partially constructed segments on-error in segment init function Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #361 (dfa066e) into branch-23.11 (8b20469) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head dfa066e differs from pull request most recent head 7d69c5d. Consider uploading reports for the commit 7d69c5d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #361      +/-   ##
================================================
+ Coverage         73.59%   73.62%   +0.03%     
================================================
  Files               385      385              
  Lines             13614    13617       +3     
  Branches           1028     1028              
================================================
+ Hits              10019    10026       +7     
+ Misses             3595     3591       -4     
Flag Coverage Δ
cpp 69.71% <100.00%> (+0.03%) ⬆️
py 42.11% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pp/mrc/src/internal/segment/builder_definition.cpp 83.53% <100.00%> (+0.30%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b20469...7d69c5d. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

Superseded by #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DO NOT MERGE non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants