Move Pycoro from Morpheus to MRC #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwharris
added
improvement
cwharris
changed the title
drobison00
approved these changes
Oct 24, 2023
|
@drobison00 yeah the only way to do that is with the CoroutineRunnable. That's a separate issue and the next PR I'm working on. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.11 #409 +/- ##
================================================
+ Coverage 73.27% 73.44% +0.16%
================================================
Files 389 392 +3
Lines 13779 13862 +83
Branches 1043 1050 +7
================================================
+ Hits 10097 10181 +84
+ Misses 3682 3681 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/merge |
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Oct 27, 2023
Depends on nv-morpheus/MRC#409 Removes the the pycoro functionality in morpheus in favor of the same functionality which was moved to mrc. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Devin Robison (https://github.com/drobison00) URL: #1313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves pycoro from Morpheus to MRC and incorperates tests from nv-morpheus/Morpheus#1286
Closes nv-morpheus/Morpheus#1268