Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Update DFP example pipeline(s) to support customized experiment and model naming, and make model names Databricks compatible. #1244

Closed
2 tasks done
drobison00 opened this issue Oct 5, 2023 · 0 comments
Assignees
Labels
feature request New feature or request

Comments

@drobison00
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

  • Static Model and Experiment names The current example DFP pipelines have static model_name_formatter and experiment_name_formatter names, which are not compatible in some Databricks environments.
  • Invalid model names Databrick's MLflow service will reject model names containing '/', '.', and ':', we also want to update model names in the mlflow stage to preprocess these accordingly.

Describe your ideal solution

Add two new click options to the dfp_xxx_pipeline.py files:

@click.option('--mlflow_experiment_name_template',
              type=str,
              default="dfp/azure/training/{reg_model_name}",
              help="The MLflow experiment name template to use when logging experiments. ")
@click.option('--mlflow_model_name_template',
              type=str,
              default="DFP-azure-{user_id}",
              help="The MLflow model name template to use when logging models. ")

Update model naming, which currently incorporates 'user_id', to replace '.', '/', ':' with 'dot', 'slash', 'colon' respectively.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@drobison00 drobison00 added the feature request New feature or request label Oct 5, 2023
@drobison00 drobison00 added this to the 23.11 - DFP Improvements milestone Oct 5, 2023
@drobison00 drobison00 self-assigned this Oct 5, 2023
rapids-bot bot pushed a commit that referenced this issue Oct 5, 2023
…ple pipelines, and make model names Databricks compatible. (#1245)

Closes issue #1244

Authors:
  - Devin Robison (https://github.com/drobison00)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant