Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Morpheus Examples link to symlinks #1356

Closed
2 tasks done
pranavm7 opened this issue Nov 12, 2023 · 2 comments · Fixed by #1357
Closed
2 tasks done

[DOC]: Morpheus Examples link to symlinks #1356

pranavm7 opened this issue Nov 12, 2023 · 2 comments · Fixed by #1357
Assignees
Labels
doc Improvements or additions to documentation external This issue was filed by someone outside of the Morpheus team Needs Triage Need team to review and classify

Comments

@pranavm7
Copy link
Contributor

pranavm7 commented Nov 12, 2023

How would you describe the priority of this documentation request

Medium

Please provide a link or source to the relevant docs

https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/docs/source/examples.md

Describe the problems in the documentation

Possible side effect of #536, the links within the Morpheus Examples document link to respective symlinks located at docs/source/examples.
However, the symlinks link to respective docs within the examples folder. This approach makes the documentation a bit difficult to read as github doesn't render symlinks, and feels a bit redundant, therefore I would like to report it as a bug.

(Optional) Propose a correction

Update links in this file from ./examples/__example_model__/README.md to ../../examples/__example_model__/README.md

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@pranavm7 pranavm7 added the doc Improvements or additions to documentation label Nov 12, 2023
@jarmak-nv jarmak-nv added Needs Triage Need team to review and classify external This issue was filed by someone outside of the Morpheus team labels Nov 12, 2023
@jarmak-nv
Copy link
Contributor

Hi @pranavm7!

Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.

@pranavm7
Copy link
Contributor Author

It is a pretty simple fix! I would like to create a PR with the same :)

pranavm7 added a commit to pranavm7/Morpheus that referenced this issue Nov 12, 2023
@dagardner-nv dagardner-nv self-assigned this Nov 13, 2023
rapids-bot bot pushed a commit that referenced this issue Nov 22, 2023
Closes #1356 : Suggested changes made in [Examples](https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/docs/source/examples.md) page! Pretty simple patch shouldn't break anything :)

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

- Pranav M

Authors:
  - Pranav Mahajan (https://github.com/pranavm7)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #1357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation external This issue was filed by someone outside of the Morpheus team Needs Triage Need team to review and classify
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants