Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: DFPFileToDataFrameStage logs messages about S3 when S3 is not being used #451

Closed
dagardner-nv opened this issue Nov 10, 2022 · 0 comments · Fixed by #1120
Closed

[BUG]: DFPFileToDataFrameStage logs messages about S3 when S3 is not being used #451

dagardner-nv opened this issue Nov 10, 2022 · 0 comments · Fixed by #1120
Assignees
@dagardner-nv
Labels
bug Something isn't working dfp [Workflow] Related to the Digital Fingerprinting (DFP) workflow

Comments

@dagardner-nv
Copy link
Contributor

Version

22.11

Which installation method(s) does this occur on?

Source

Describe the bug.

There are log messages and variable names in the code that are largely historical, and can be confusing to users.

Minimum reproducible example

Run one of the example pipelines in `examples/digital_fingerprinting/production`

Relevant log output

No response

Full env printout

S3 objects to DF complete. Rows: 2000000, Cache: miss, Duration: 60602.33426094055 ms


### Other/Misc.

_No response_

### Code of Conduct

- [X] I agree to follow Morpheus' Code of Conduct
- [X] I have searched the [open bugs](https://github.com/nv-morpheus/Morpheus/issues?q=is%3Aopen+is%3Aissue+label%3Abug) and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Nov 10, 2022
@dagardner-nv dagardner-nv mentioned this issue Aug 4, 2023
Merged
3 tasks
@dagardner-nv dagardner-nv self-assigned this Aug 4, 2023
@mdemoret-nv mdemoret-nv added the dfp [Workflow] Related to the Digital Fingerprinting (DFP) workflow label Aug 21, 2023
rapids-bot bot pushed a commit that referenced this issue Aug 22, 2023
@dagardner-nv
Fix issue where DFPFileToDataFrameStage logs messages about S3 even w…
c92e212 
…hen S3 is not in use (#1120)

* `DFPFileToDataFrameStage` is no longer an S3 specific stage, but some of the log messages and the `unique-name` still refer to S3.

Fixes #451

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Christopher Harris (https://github.com/cwharris)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working dfp [Workflow] Related to the Digital Fingerprinting (DFP) workflow
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
2 participants
@mdemoret-nv @dagardner-nv