Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Make graphviz rankdir configurable #643

Closed
2 tasks done
nvawood opened this issue Jan 27, 2023 · 2 comments · Fixed by #1119
Closed
2 tasks done

[FEA]: Make graphviz rankdir configurable #643

nvawood opened this issue Jan 27, 2023 · 2 comments · Fixed by #1119
Assignees
Labels
feature request New feature or request good first issue Good for newcomers

Comments

@nvawood
Copy link

nvawood commented Jan 27, 2023

Is this a new feature, an improvement, or a change to existing functionality?

Change

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

I want Morpheus to support changing the direction of Graphviz pipeline images, because I find longer pipelines difficult to visualize in a left-to-right format.

Describe your ideal solution

A new command line parameter that sets the rankdir argument.

@click.option('--viz_direction',
              default="LR",
              type=click.Choice(["LR", "TB", "BT", "RL"], case_sensitive=True),
              help="Set the direction for the Graphviz pipeline diagram.")

pipeline.visualize(kwargs["viz_file"], rankdir=viz_direction)

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@nvawood nvawood added the feature request New feature or request label Jan 27, 2023
@mdemoret-nv
Copy link
Contributor

@nvawood rankdir can currently be configured if you use the Pipeline.visualize("my_file.png", rankdir="TB") method. Does this satisfy this request or do you need it part of the CLI?

@nvawood
Copy link
Author

nvawood commented Mar 29, 2023

I think if it's going to remain an option in the CLI, then it should be configurable there as well.

rapids-bot bot pushed a commit that referenced this issue Aug 17, 2023
* Add a `--viz_direction` flag to CLI
* Cherry-pick'd [9532bfe](9532bfe) from @mdemoret-nv 

fixes #643

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Christopher Harris (https://github.com/cwharris)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants