You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this a new feature, an improvement, or a change to existing functionality?
Change
How would you describe the priority of this feature request
High
Please provide a clear description of problem this feature solves
Running stubgen in CI requires the Nvidia drivers to be installed in the CI image. This unfortunately locks us to a specific driver version, and ops would like to accelerate adopting new versions.
Describe your ideal solution
Include the stubs as part of the source code and add a CI check to make sure they are up to date
This would shift generating the stubs to the developer (can still be part of the build. The dev just needs to commit them)
The test in CI could happen in the test stage which already has a GPU
The test would be as simple as running the stubgen code and seeing if there are any diffs. Similar to what we do for clang-format
Describe any alternatives you have considered
See if the cuda-toolkit driver stubs work the same as cudatoolkit
If we can load the stubs but not run anything, that would work for us. The current stubs throw an error on load.
This is a long shot but requires the least amount of work
Generate the stubs in a pre-commit hook
Additional context
No response
Code of Conduct
I agree to follow this project's Code of Conduct
I have searched the open feature requests and have found no duplicates for this feature request
The text was updated successfully, but these errors were encountered:
This PR changes the stub generation to be committed into the repo instead of as part of the build. This will allow CI steps that need the PYI files to not require a GPU as well.
This works by always copying the PYI files back to the source tree so they will show up as diffs. Any diffs during the test phase will be reported as an error.
Closes#766
Authors:
- Michael Demoret (https://github.com/mdemoret-nv)
- David Gardner (https://github.com/dagardner-nv)
Approvers:
- Christopher Harris (https://github.com/cwharris)
- David Gardner (https://github.com/dagardner-nv)
URL: #1111
Is this a new feature, an improvement, or a change to existing functionality?
Change
How would you describe the priority of this feature request
High
Please provide a clear description of problem this feature solves
Running stubgen in CI requires the Nvidia drivers to be installed in the CI image. This unfortunately locks us to a specific driver version, and ops would like to accelerate adopting new versions.
Describe your ideal solution
Include the stubs as part of the source code and add a CI check to make sure they are up to date
Describe any alternatives you have considered
See if the cuda-toolkit driver stubs work the same as cudatoolkit
If we can load the stubs but not run anything, that would work for us. The current stubs throw an error on load.
This is a long shot but requires the least amount of work
Generate the stubs in a pre-commit hook
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: