Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conda's base pip (CVE) #1024

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

pdmack
Copy link
Contributor

@pdmack pdmack commented Jul 7, 2023

Description

Marginally improve the CVE posture of the released image by removing conda's base pip exe.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pdmack pdmack added dependencies Pull requests that update a dependency file non-breaking Non-breaking change 3 - Ready for Review labels Jul 7, 2023
@pdmack pdmack requested a review from a team as a code owner July 7, 2023 16:25
@pdmack pdmack added the improvement Improvement to existing functionality label Jul 7, 2023
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My big concern here is that some of the examples require additional dependencies such as examples/gnn_fraud_detection_pipeline which in turn requires the user to have pipe installed in the Docker container.

docker/Dockerfile Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 38e3696 into nv-morpheus:branch-23.07 Jul 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants