Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and examples to use Triton 23.06 #1037

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Jul 11, 2023

Description

  • Update docs and examples to use Triton 23.06
  • Most examples are using 22.08. Significant speedup is seen in ONNX->TRT conversion that happens in first inference run of the pipeline (e.g. SID).

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Jul 11, 2023
@efajardo-nv efajardo-nv marked this pull request as ready for review July 11, 2023 22:27
@efajardo-nv efajardo-nv requested review from a team as code owners July 11, 2023 22:27
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Going to merge this after running val scripts locally

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 4ef44cf into nv-morpheus:branch-23.07 Jul 12, 2023
4 checks passed
@mdemoret-nv mdemoret-nv deleted the update-triton branch July 12, 2023 23:54
@mdemoret-nv
Copy link
Contributor

For reference, using 23.06 has significantly sped up the validation scripts by about ~50%:

# 23.06
real    3m24.425s
user    2m46.757s
sys     0m30.639s

# 22.08
real    7m6.385s
user    6m18.460s
sys     0m57.667s

Most of this is due to the improved ONNX->TRT conversion in Triton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants