Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix models scripts/notebooks #1051

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Fix models scripts/notebooks #1051

merged 3 commits into from
Jul 13, 2023

Conversation

tzemicheal
Copy link
Contributor

@tzemicheal tzemicheal commented Jul 12, 2023 •
edited
Loading

Description

  • Update broken reference in the hamma_inference script
  • Fix ABP notebook scoring of cupy/cudf output to numpy.
  • Fix AutoEncoder parameters in Hammah notebook.
  • Add peridicity_detection module for hamma inference.

Closes #1052

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@tzemicheal tzemicheal requested a review from a team as a code owner July 12, 2023 20:42
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@tzemicheal tzemicheal requested a review from hsin-c July 12, 2023 20:43
hsin-c
hsin-c approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@hsin-c hsin-c left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can merge after CI passed.

@tzemicheal tzemicheal added the bug Something isn't working label Jul 12, 2023
@raykallen
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 7c2db78 into nv-morpheus:branch-23.07 Jul 13, 2023
4 checks passed
@tzemicheal tzemicheal deleted the models_check_tad branch August 30, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raykallen raykallen raykallen approved these changes

@hsin-c hsin-c hsin-c approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Data Science non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Some notebook & scripts in models don't run
3 participants
@tzemicheal @raykallen @hsin-c