Fix intermittent failures in test_dfencoder_distributed_e2e test #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only applies to the parent process. Set encoding and use a context manager for file reads
dagardner-nv
added
bug
|
#1021 doesn't mention a cause, nor does this PR. Can we get a description of why the failure was occuring and how it's been fixed? that way it shows up in git logs. |
cwharris
approved these changes
Aug 10, 2023
mdemoret-nv
approved these changes
Aug 22, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
manual_seedmethod from within the subprocess, this ensures the subprocess runs deterministically.morpheus/models/dfencoder/multiprocessing.pyfixes #1021
Checklist