Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings and tests for LangChainAgentNode #1327

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Docstrings and tests for LangChainAgentNode #1327

merged 5 commits into from
Oct 31, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 31, 2023 •
edited
Loading

Description

  • Add docstrings for LangChainAgentNode
  • Add tests for LangChainAgentNode

Closes #1299

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner October 31, 2023 21:53
@dagardner-nv dagardner-nv marked this pull request as draft October 31, 2023 21:54
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality sherlock Issues/PRs related to Sherlock workflows and components labels Oct 31, 2023
@dagardner-nv dagardner-nv changed the title Draft: fea sherlock lang chain agent Draft: Docstrings and tests for LangChainAgentNode Oct 31, 2023
@dagardner-nv dagardner-nv self-assigned this Oct 31, 2023
@dagardner-nv dagardner-nv changed the title Draft: Docstrings and tests for LangChainAgentNode Docstrings and tests for LangChainAgentNode Oct 31, 2023
@dagardner-nv dagardner-nv marked this pull request as ready for review October 31, 2023 21:56
@dagardner-nv dagardner-nv merged commit 4692529 into nv-morpheus:fea-sherlock Oct 31, 2023
15 of 16 checks passed
@dagardner-nv dagardner-nv deleted the david-fea-sherlock-lang-chain-agent branch October 31, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @drobison00