Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve camouflage startup issues #1436

Merged
merged 13 commits into from
Dec 20, 2023
Merged

Improve camouflage startup issues #1436

merged 13 commits into from
Dec 20, 2023

Commits on Dec 14, 2023

  1. Resolve camouflage statup issues by increasing timeout to 30 seconds. 

    Improve camouflage error reporting by redirecting stdout and stderr to a file.
This is a work-around for not being able to control the log level of camouflage's console logger
testinggospels/camouflage#244

We can't redirect stdout/stderr to a PIPE since on successful startup the PIPE would fill and block
camouflage. On the other hand sending stdout/stderr to /dev/null prevents users from seeing errors
from the shell/OS regarding camouflage failing to start.
    @dagardner-nv
    dagardner-nv committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    0978763 View commit details
    Browse the repository at this point in the history

  2. formatting

    @dagardner-nv
    dagardner-nv committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    9d0945d View commit details
    Browse the repository at this point in the history

  3. Switch to invoking camouflage via npx, allowing it to be installed on… 

    …-demand
    @dagardner-nv
    dagardner-nv committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    8998fb2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-24.03' into david-camouflage-ci-1417

    @dagardner-nv
    dagardner-nv authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    dccccae View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Don't perform a global install since npx only works with locally inst… 

    …alled packages
    @dagardner-nv
    dagardner-nv committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e61fbd3 View commit details
    Browse the repository at this point in the history

  2. WIP, need to determine a way to spawn in a new process group

    @dagardner-nv
    dagardner-nv committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e837118 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Launch camouflage in a new process group

    @dagardner-nv
    dagardner-nv committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0d6a876 View commit details
    Browse the repository at this point in the history

  2. Set a WORKDIR, fixing the npm install issue

    @dagardner-nv
    dagardner-nv committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    20b6940 View commit details
    Browse the repository at this point in the history

  3. Revert "Set a WORKDIR, fixing the npm install issue" 

    This reverts commit 20b6940.
    @dagardner-nv
    dagardner-nv committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7c18f41 View commit details
    Browse the repository at this point in the history

  4. Revert "Launch camouflage in a new process group" 

    This reverts commit 0d6a876.
    @dagardner-nv
    dagardner-nv committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b420bad View commit details
    Browse the repository at this point in the history

  5. Revert "WIP, need to determine a way to spawn in a new process group" 

    This reverts commit e837118.
    @dagardner-nv
    dagardner-nv committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    26c0899 View commit details
    Browse the repository at this point in the history

  6. Revert "Don't perform a global install since npx only works with loca… 

    …lly installed packages"

This reverts commit e61fbd3.
    @dagardner-nv
    dagardner-nv committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    06121e4 View commit details
    Browse the repository at this point in the history

  7. Revert "Switch to invoking camouflage via npx, allowing it to be inst… 

    …alled on-demand"

This reverts commit 8998fb2.
    @dagardner-nv
    dagardner-nv committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    57dc22c View commit details
    Browse the repository at this point in the history