-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cupy_to_tensor
to also infer uint8
and int8
dtypes
#1621
Fix cupy_to_tensor
to also infer uint8
and int8
dtypes
#1621
Conversation
cupy_to_tensor
to infer uint8
and int8
dtypescupy_to_tensor
to also infer uint8
and int8
dtypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great opportunity to add some testing here on the DType object. Lets add tests which check for correct functionality for all supported numpy types (within reason)
…into from-numpy-dtype-fix
…into from-numpy-dtype-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great new tests! These are perfect examples of unit testing.
/merge |
Description
DType::from_numpy
to handle strings that identifyuint8
andint8
dtypesCloses #1619
By Submitting this PR I confirm: