Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid private cudf DeviceScalar in favor of using pylibcudf & pyarrow #2090

Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from

Conversation

mroeschke
Copy link
Contributor

Description

In cudf, I'm looking to ultimately remove the DeviceScalar implementation in favor of using pylibcudf.Scalar and pyarrow.

Before, it appears there was a cudf helper from getting an element from a string column's child (offset) column. There now exists pylibcudf APIs to do this and therefore can avoid having to directly access DeviceScalar

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner December 19, 2024 21:50
Copy link

copy-pr-bot bot commented Dec 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review - Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant