Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more details to E2E benchmarks README #395

Merged
4 commits merged into from
Oct 14, 2022
Merged

Add more details to E2E benchmarks README #395

4 commits merged into from
Oct 14, 2022

Conversation

efajardo-nv
Copy link
Contributor

Add the following to E2E benchmarks README to make it more consumable to general audience:

  • Instructions to set up Morpheus Dev container
  • Info on how to manage Morpheus configs for each workflow
  • Add warmup option to account for ONNX->TRT conversion during first run
  • Information on fields added to JSON report by custom hook

@efajardo-nv efajardo-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels Oct 6, 2022
@efajardo-nv efajardo-nv requested a review from a team as a code owner October 6, 2022 20:03
@efajardo-nv efajardo-nv changed the base branch from branch-22.09 to branch-22.11 October 6, 2022 20:03
mdemoret-nv
mdemoret-nv approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small changes, but overall it looks good

tests/benchmarks/README.md Outdated Show resolved Hide resolved
tests/benchmarks/README.md Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 93f8bda into nv-morpheus:branch-22.11 Oct 14, 2022
@dagardner-nv dagardner-nv mentioned this pull request Sep 21, 2023
Merged
@efajardo-nv efajardo-nv deleted the e2e-benchmarks-readme-updates branch July 29, 2024 21:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efajardo-nv @mdemoret-nv