Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin camouflage to v0.9 and ensure pytest-benchmark>=4 #416

Merged
4 commits merged into from
Oct 27, 2022

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 25, 2022

v0.10 was released on 2022-10-25 and completely breaks our tests which depends on it.
pytest-benchmark 4.0 fixes an incompatibility with pytest 7.2

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 2 - In Progress labels Oct 25, 2022
@dagardner-nv dagardner-nv requested a review from a team as a code owner October 25, 2022 23:03
@dagardner-nv dagardner-nv changed the title Update config for camouflage to work with v0.10.0 Pin camouflage to v0.9 Oct 25, 2022
@dagardner-nv dagardner-nv changed the title Pin camouflage to v0.9 Pin camouflage to v0.9 and ensure pytest-benchmark>=4 Oct 26, 2022
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question

docker/conda/environments/requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagardner-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit 2bd4961 into nv-morpheus:branch-22.11 Oct 27, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants