-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sccache
bucket
#693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the `sccache` configuration settings to use a new bucket, `rapids-sccache-east`. Unlike the previous `rapids-sccache` bucket, `rapids-sccache-east` resides in the same AWS region as the rest of our CI infrastructure (`us-east-2`). This should result in faster, more reliable `sccache` connections and will also help keep our data transfer costs down. **Important Note**: The changes from [this `sccache` PR](mozilla/sccache#1403) are required to use a bucket in `us-east-2`. These changes were incorporated in `sccache` `v0.3.2`, so you'll need that version or later (preferably the latest, `v0.3.3`). Please ensure that your CI images satisfy this constraint before merging this PR. Additionally, this PR updates the `SCCACHE_REGION` to the region of the bucket. This value is not meant to be a variable.
ajschmidt8
added
non-breaking
Non-breaking change
improvement
Improvement to existing functionality
labels
Feb 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I checked, our images are using 0.3.1. I'll push up new images this morning.
Adopt updated CI runner with sccache 0.3.3 & merge branch-23.03 changes
dagardner-nv
approved these changes
Feb 14, 2023
/merge |
jjacobelli
pushed a commit
to jjacobelli/Morpheus
that referenced
this pull request
Mar 7, 2023
This PR updates the `sccache` configuration settings to use a new bucket, `rapids-sccache-east`. Unlike the previous `rapids-sccache` bucket, `rapids-sccache-east` resides in the same AWS region as the rest of our CI infrastructure (`us-east-2`). This should result in faster, more reliable `sccache` connections and will also help keep our data transfer costs down. **Important Note**: The changes from [this `sccache` PR](mozilla/sccache#1403) are required to use a bucket in `us-east-2`. These changes were incorporated in `sccache` `v0.3.2`, so you'll need that version or later (preferably the latest, `v0.3.3`). Please ensure that your CI images satisfy this constraint before merging this PR. Additionally, this PR updates the `SCCACHE_REGION` to the region of the bucket. This value is not meant to be a variable. Authors: - AJ Schmidt (https://github.com/ajschmidt8) - David Gardner (https://github.com/dagardner-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: nv-morpheus#693
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
sccache
configuration settings to use a new bucket,rapids-sccache-east
.Unlike the previous
rapids-sccache
bucket,rapids-sccache-east
resides in the same AWS region as the rest of our CI infrastructure (us-east-2
).This should result in faster, more reliable
sccache
connections and will also help keep our data transfer costs down.Important Note: The changes from this
sccache
PR are required to use a bucket inus-east-2
. These changes were incorporated insccache
v0.3.2
, so you'll need that version or later (preferably the latest,v0.3.3
). Please ensure that your CI images satisfy this constraint before merging this PR.Additionally, this PR updates the
SCCACHE_REGION
to the region of the bucket. This value is not meant to be a variable.