Pre-allocate needed columns in abp_pcap_detection example #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed out here since the original is large and not part of the dataset pulled by the test stage in CI
dagardner-nv
added
non-breaking
mdemoret-nv
approved these changes
Apr 10, 2023
…cap_preprocessing-pre-allocating-797
This reverts commit d7e23be.
…potentially not in the sys.path
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AbpPcapPreprocessingStagerequests needed columns to be pre-allocatedAbpPcapPreprocessingStage(part of [FEA]: Create tests for custom stages in examples #849)tests/tests_data/abp_pcap.jsonlineswhich is the first 20 lines of the much largerexamples/data/abp_pcap_dump.jsonlines(200MB) which is not downloaded in the test CI stage.fixes #797
Checklist