Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multi-sender stage configurations #951

Merged
merged 2 commits into from
May 19, 2023

Conversation

mdemoret-nv
Copy link
Contributor

Description

This PR fixes a long overdue placeholder exception from back when we were still using streamz. If a user configured multiple upstream stages to a single downstream port, then you would get a NotImplementedError. For example, the following would cause an exception:

source1 = pipe.add_stage(InMemorySourceStage(config, [filter_probs_df]))
source2 = pipe.add_stage(InMemorySourceStage(config, [filter_probs_df]))

sink_stage = pipe.add_stage(InMemorySinkStage(config))

pipe.add_edge(source1, sink_stage)
pipe.add_edge(source2, sink_stage)

Also adds a simple tests to run the above scenario.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels May 17, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner May 17, 2023 02:05
@mdemoret-nv
Copy link
Contributor Author

Discovered when reviewing PR #939

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

morpheus/pipeline/receiver.py Outdated Show resolved Hide resolved
@drobison00
Copy link
Contributor

Looks good and a really useful functionality bump.

Co-authored-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 23ae068 into nv-morpheus:branch-23.07 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants