-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn and cast to cudf, when the C++ impl for MessageMeta receives a pandas DF #985
Merged
rapids-bot
merged 12 commits into
nv-morpheus:branch-23.07
from
dagardner-nv:david-cpp-msg-pandas-811
Jun 21, 2023
Merged
Warn and cast to cudf, when the C++ impl for MessageMeta receives a pandas DF #985
rapids-bot
merged 12 commits into
nv-morpheus:branch-23.07
from
dagardner-nv:david-cpp-msg-pandas-811
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
bug
Something isn't working
non-breaking
Non-breaking change
3 - Ready for Review
labels
Jun 13, 2023
…rator, this avoids the pylint warning about re-defining a name from an outer-scope.
…, remove redundant fixture, as @pytest.mark.use_cpp will ensure that we only receive cudf dataframes
mdemoret-nv
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge after the 2 comments have been resolved
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MessageMeta
only supports cudf DataFrames, passing it a Pandas DF creates unexpected behavior.morpheus/modules/from_control_message.py
,ControlMessage.payload()
returns aMessageMeta
not a Dataframe.tests/modules/test_to_control_message.py
fixtures don't work as values inpytest.mark.parametrize
ci/scripts/cpp_checks.sh
fixes #811
Checklist