Enable unicode normalization by default for speech (#17017)

Fixes #16616 Summary of the issue: In #16521, Unicode normalization was added, but it is disabled by default. Description of user facing changes Unicode normalization is now enabled by default for Speech. Description of development approach Change default values
nvaccess · Sep 9, 2024 · 6610e4b · 6610e4b
1 parent 7e526e8
commit 6610e4b
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 3 deletions.
diff --git a/source/config/configSpec.py b/source/config/configSpec.py
@@ -35,7 +35,7 @@
 	# symbolLevel: One of the characterProcessing.SymbolLevel values.
 	symbolLevel = integer(default=100)
 	trustVoiceLanguage = boolean(default=true)
-	unicodeNormalization = featureFlag(optionsEnum="BoolFlag", behaviorOfDefault="disabled")
+	unicodeNormalization = featureFlag(optionsEnum="BoolFlag", behaviorOfDefault="enabled")
 	reportNormalizedForCharacterNavigation = boolean(default=true)
 	# Deprecated in 2025.1
 	includeCLDR = boolean(default=True)

diff --git a/tests/system/nvdaSettingsFiles/standard-doShowWelcomeDialog.ini b/tests/system/nvdaSettingsFiles/standard-doShowWelcomeDialog.ini
@@ -9,6 +9,7 @@ schemaVersion = 2
 	allowUsageStats = False
 [speech]
 	synth = speechSpySynthDriver
+	unicodeNormalization = DISABLED
 [development]
 	enableScratchpadDir = True
 [virtualBuffers]

diff --git a/tests/system/nvdaSettingsFiles/standard-dontShowExitDialog.ini b/tests/system/nvdaSettingsFiles/standard-dontShowExitDialog.ini
@@ -10,6 +10,7 @@ schemaVersion = 2
 	allowUsageStats = False
 [speech]
 	synth = speechSpySynthDriver
+	unicodeNormalization = DISABLED
 [development]
 	enableScratchpadDir = True
 [virtualBuffers]

diff --git a/tests/system/nvdaSettingsFiles/standard-dontShowWelcomeDialog.ini b/tests/system/nvdaSettingsFiles/standard-dontShowWelcomeDialog.ini
@@ -9,6 +9,7 @@ schemaVersion = 2
 	allowUsageStats = False
 [speech]
 	synth = speechSpySynthDriver
+	unicodeNormalization = DISABLED
 [development]
 	enableScratchpadDir = True
 [virtualBuffers]

diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md
@@ -5,6 +5,7 @@
 ### Important notes
 
 ### New Features
+
 * The volume of other applications can be adjusted by `NVDA+alt+pageUp` and `NVDA+alt+pageDown`. In order to use this feature, application volume adjuster needs to be enabled in Audio pane of NVDA settings. (#16052, @mltony)
 * Added command to mute or unmute all other applications, assigned to `NVDA+alt+delete`.
 In order to use this feature, the application volume adjuster needs to be enabled in the Audio category of NVDA settings. (#16052, @mltony)
@@ -18,6 +19,8 @@ In order to use this feature, the application volume adjuster needs to be enable
 
 * The Report link destination, Character formatting information, and Speak selection dialogs, now include "Close" and "Copy" buttons for user convenience. (#17018, @XLTechie)
 * The exit dialog now allows you to restart NVDA with add-ons disabled and debug logging enabled simultaneously. (#11538, @CyrilleB79)r
+* Unicode Normalization is now enabled by default for speech output. (#17017, @LeonarddeR).
+  * You can still disable this functionality in the Speech category of the NVDA Settings dialog.
 
 ### Bug Fixes
 

diff --git a/user_docs/en/userGuide.md b/user_docs/en/userGuide.md
@@ -1914,8 +1914,8 @@ If you find that NVDA is reading punctuation in the wrong language for a particu
 ##### Unicode normalization {#SpeechUnicodeNormalization}
 | . {.hideHeaderRow} |.|
 |---|---|
-|Options |Default (Disabled), Enabled, Disabled|
-|Default |Disabled|
+|Options |Default (Enabled), Enabled, Disabled|
+|Default |Enabled|
 
 When this option is enabled, unicode normalization is performed on the text that is spoken by NVDA.
 This is beneficial when speaking characters that can be represented in several forms.