Skip to content

Commit

Permalink
Style.
Browse files Browse the repository at this point in the history
  • Loading branch information
codeofdusk committed Jan 24, 2020
1 parent 8d4a2b3 commit cea6aca
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 18 deletions.
4 changes: 1 addition & 3 deletions source/NVDAObjects/UIA/winConsoleUIA.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# A part of NonVisual Desktop Access (NVDA)
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
# Copyright (C) 2019 Bill Dengler
# Copyright (C) 2019-2020 Bill Dengler

import ctypes
import NVDAHelper
Expand Down Expand Up @@ -112,7 +112,6 @@ def collapse(self, end=False):
UIAHandler.TextPatternRangeEndpoint_Start
)


def compareEndPoints(self, other, which):
"""Works around a UIA bug on Windows 10 1803 to 2004."""
# Even when a console textRange's start and end have been moved to the
Expand Down Expand Up @@ -277,7 +276,6 @@ def _isCollapsed(self):
and will return an empty string."""
return not bool(self._rangeObj.getText(1))


def _get_isCollapsed(self):
# To decide if the textRange is collapsed,
# Check if it has no text.
Expand Down
2 changes: 1 addition & 1 deletion source/UIAUtils.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2015-2019 NV Access Limited, Bill Dengler
# Copyright (C) 2015-2020 NV Access Limited, Bill Dengler
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.

Expand Down
25 changes: 14 additions & 11 deletions source/gui/settingsDialogs.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# -*- coding: UTF-8 -*-
# settingsDialogs.py
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2006-2019 NV Access Limited, Peter Vágner, Aleksey Sadovoy,
# Copyright (C) 2006-2020 NV Access Limited, Peter Vágner, Aleksey Sadovoy,
# Rui Batista, Joseph Lee, Heiko Folkerts, Zahari Yurukov, Leonard de Ruijter,
# Derek Riemer, Babbage B.V., Davy Kager, Ethan Holliger, Bill Dengler
# This file is covered by the GNU General Public License.
Expand Down Expand Up @@ -2423,16 +2423,19 @@ def _getDefaultValue(self, configPath):

def haveConfigDefaultsBeenRestored(self):
return (
self._defaultsRestored and
self.scratchpadCheckBox.IsChecked() == self.scratchpadCheckBox.defaultValue and
self.UIAInMSWordCheckBox.IsChecked() == self.UIAInMSWordCheckBox.defaultValue and
self.consoleCombo.GetSelection() == self.consoleCombo.defaultValue and
self.speakPasswordsCheckBox.IsChecked() == self.speakPasswordsCheckBox.defaultValue and
self.keyboardSupportInLegacyCheckBox.IsChecked() == self.keyboardSupportInLegacyCheckBox.defaultValue and
self.autoFocusFocusableElementsCheckBox.IsChecked() == self.autoFocusFocusableElementsCheckBox.defaultValue and
self.caretMoveTimeoutSpinControl.GetValue() == self.caretMoveTimeoutSpinControl.defaultValue and
set(self.logCategoriesList.CheckedItems) == set(self.logCategoriesList.defaultCheckedItems) and
True # reduce noise in diff when the list is extended.
self._defaultsRestored
and self.scratchpadCheckBox.IsChecked() == self.scratchpadCheckBox.defaultValue
and self.UIAInMSWordCheckBox.IsChecked() == self.UIAInMSWordCheckBox.defaultValue
and self.consoleCombo.GetSelection() == self.consoleCombo.defaultValue
and self.speakPasswordsCheckBox.IsChecked() == self.speakPasswordsCheckBox.defaultValue
and self.keyboardSupportInLegacyCheckBox.IsChecked() == self.keyboardSupportInLegacyCheckBox.defaultValue
and (
self.autoFocusFocusableElementsCheckBox.IsChecked()
== self.autoFocusFocusableElementsCheckBox.defaultValue
)
and self.caretMoveTimeoutSpinControl.GetValue() == self.caretMoveTimeoutSpinControl.defaultValue
and set(self.logCategoriesList.CheckedItems) == set(self.logCategoriesList.defaultCheckedItems)
and True # reduce noise in diff when the list is extended.
)

def restoreToDefaults(self):
Expand Down
4 changes: 2 additions & 2 deletions source/winVersion.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2006-2019 NV Access Limited
# Copyright (C) 2006-2020 NV Access Limited, Bill Dengler
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.

Expand Down Expand Up @@ -37,7 +37,7 @@ def isUwpOcrAvailable():
1809: 17763,
1903: 18362,
1909: 18363,
2004: 19551, # Placeholder, fix once it goes stable
2004: 19551, # Placeholder, fix once it goes stable
}


Expand Down
2 changes: 1 addition & 1 deletion user_docs/en/userGuide.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -1798,7 +1798,7 @@ However, you may wish to enable it if you experience performance issues or insta
==== Use the new typed character support in legacy Windows consoles when available ====[AdvancedSettingsKeyboardSupportInLegacy]
This option enables an alternative method for detecting typed characters in legacy Windows consoles.
While it improves performance and prevents some console output from being spelled out, it may be incompatible with some terminal programs.
This feature is available and enabled by default on Windows 10 version 1607 through 1909 as well as on newer Windows 10 releases when UI Automation is unavailable or disabled.
This feature is available and enabled by default on Windows 10 versions 1607 through 1909 as well as on newer Windows 10 releases when UI Automation is unavailable or disabled.
Warning: with this option enabled, typed characters that do not appear onscreen, such as passwords, will not be suppressed.
In untrusted environments, you may temporarily disable [speak typed characters #KeyboardSettingsSpeakTypedCharacters] and [speak typed words #KeyboardSettingsSpeakTypedWords] when entering passwords.

Expand Down

0 comments on commit cea6aca

Please sign in to comment.