Merge pull request #17353 from nvaccess/rc

Provide speech symbols file name path on creation (#17346)

source/buildVersion.py

@@ -65,7 +65,7 @@ def formatVersionForGUI(year, major, minor):
 name = "NVDA"
 version_year = 2024
 version_major = 4
-version_minor = 0
+version_minor = 1
 version_build = 0  # Should not be set manually. Set in 'sconscript' provided by 'appVeyor.yml'
 version = _formatDevVersionString()
 publisher = "unknown"

source/characterProcessing.py

@@ -237,11 +237,11 @@ class SpeechSymbols:
 	This is all handled by L{SpeechSymbolProcessor}.
 	"""
 
-	def __init__(self):
+	def __init__(self, filename: str | None = None):
 		"""Constructor."""
 		self.complexSymbols = collections.OrderedDict()
 		self.symbols = collections.OrderedDict()
-		self.fileName = None
+		self.fileName = filename
 
 	def load(self, fileName: str, allowComplexSymbols: bool = True) -> None:
 		"""Load symbol information from a file.
@@ -826,7 +826,7 @@ def getSymbols(self, locale: str) -> SpeechSymbols:
 
 	def _initSymbols(self, locale: str) -> SpeechSymbols:
 		raiseOnError = self.source != _SymbolDefinitionSource.USER
-		symbols = SpeechSymbols()
+		symbols = SpeechSymbols(self.path.format(locale=locale))
 		if locale not in self.availableLocales:
 			msg = f"No {self.name!r} data for locale {locale!r}"
 			if raiseOnError:

user_docs/en/changes.md

@@ -1,5 +1,13 @@
 # What's New in NVDA
 
+## 2024.4.1
+
+It also includes a fix for saving speech symbol dictionaries.
+
+### Bug fixes
+
+* Fixed bug where speech symbols dictionaries were not saved and the dialog would not be closed. (#17344)
+
 ## 2024.4
 
 This release includes a number of improvements in Microsoft Office, braille, and document formatting.