-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
role="alert" with div element is read twice #6680
Comments
@tapanbasak is this still an issue with the latest version of NVDA? Do you have an example site that is demonstrating this behavior? |
@tapanbasak are you still available? |
Hi @ehollig, @Adriani90, I can say that it still reproduces for me in IE11 with NVDA 2019.1. It reads "You have removed the item alert You have removed the item". Code sample:
|
Issue: - The current alert function uses a workaround to avoid NVDA reading the alert message twice (NVDA bug: nvaccess/nvda#6680). - However, understanding now that it breaks other SR program's functionality, we should implement it the correct way without working around NVDA's bug Changes: - Fixing implementation for ARIAUtils.alert - Instead of changing a description element for an alert element, we are applying the text change to the alert element directly. Bug: 1120844 Change-Id: Ic4fc8a99a56b3ce61948c9cf91308adf0d72d30c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2368771 Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com> Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Issue: - The current alert function uses a workaround to avoid NVDA reading the alert message twice (NVDA bug: nvaccess/nvda#6680). - However, understanding now that it breaks other SR program's functionality, we should implement it the correct way without working around NVDA's bug Changes: - Fixing implementation for ARIAUtils.alert - Instead of changing a description element for an alert element, we are applying the text change to the alert element directly. Bug: 1120844 Change-Id: Ic4fc8a99a56b3ce61948c9cf91308adf0d72d30c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2368771 Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com> Commit-Queue: Michael Liao <michael.liao@microsoft.com>
We have the same issue in Chrome and Firefox. The fix of using aria-described by is not possible because we are using NGBModal options where only ariaLabelledBy is available. Additionally, we need the entire modal content to read and can't just set a custom aria-label for the element being used with described by. Is there any update on this issue? |
NVDA does nothing against Aria specs here, the current behavior is intended. The span text is reported because this is where NVDA's virtual cursor lands to in browse mode, and the aria live message is reported according to aria spec. |
When role="alert" is added to a div element, inner content is reading twice by NVDA reader (version >=2016.1) with IE11 browser. In chrome it is working fine as expected. For example -
<div class="validation-message-danger" style="display:none;" role="alert" id="c3text_err_1_inline_minLength">This field is required</div>
When above div element is made visible, NVDA reader is reading like "This field is required alert This field is required" in IE 11 browser.
If anyone has any workaround, please suggest...
Thanks
The text was updated successfully, but these errors were encountered: