Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing NVDA Service also removed win32api, which cause problems for some add-ons #7642

Closed
Brian1Gaff opened this issue Oct 3, 2017 · 10 comments

Comments

@Brian1Gaff
Copy link

When I installed as a portable version, but left the old user config file so the add ons etc would be loaded I got this error on running either the installer or the finished portable version.
ERROR - globalPluginHandler.listPlugins (12:03:44.404):
Error importing global plugin goldenCursor
Traceback (most recent call last):
File "globalPluginHandler.pyc", line 22, in listPlugins
File "C:\Users\Brian\AppData\Roaming\nvda\addons\goldenCursor\globalPlugins\goldenCursor.py", line 24, in
ImportError: No module named win32api

Seems to be rather a vital omission??

@Brian1Gaff
Copy link
Author

Added the complete log for a clean install into a portable version showing the error in the add on. the version of the snap is the first one to create this error. Note if you are updating a previous portable version the chances are due to old files still in the folder the error will not appear in the running portable version, which is probably why this loss of a function was missed during creation of this snap.
Brian

@LeonarddeR LeonarddeR changed the title Missing file in latest next snap? Removing NVDA Service also removed win32api, which cause problems for some add-ons Oct 10, 2017
@fisher729
Copy link

I think this issue should be closed, as it doesn't affect NVDA itself, but external components. I think a PSA is in order on some forum, though. Just my thoughts.

@josephsl
Copy link
Collaborator

josephsl commented Oct 16, 2017 via email

@LeonarddeR
Copy link
Collaborator

I think there should at least be a transision period for new add-ons to be updated. 2018.1 is ok for that, but I belief at least 2017.4 should still contain this dependency.

@derekriemer
Copy link
Collaborator

Is this even a big module? I ask because this and win32con are extremely useful for addons, and removing this might hinder some addon development quite a lot. I would rather not see ten different versions of win32api in 10 different addons if we can stop it.

@Brian1Gaff
Copy link
Author

Brian1Gaff commented Oct 17, 2017 via email

@Brian1Gaff
Copy link
Author

Brian1Gaff commented Oct 17, 2017 via email

@Adriani90
Copy link
Collaborator

As I am understanding this issue correctly, it was reproduced in Windows XP or Vista. Can you reproduce it in Windows 7 or higher? I am using Golden Cursor and am not able to reproduce it on Windows 8.1 or Windows 10.
cc: @josephsl

@LeonarddeR
Copy link
Collaborator

win32api is manually included nowadays, so I'm going to close this. Removing it again is a different issue IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants