-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing NVDA Service also removed win32api, which cause problems for some add-ons #7642
Comments
Added the complete log for a clean install into a portable version showing the error in the add on. the version of the snap is the first one to create this error. Note if you are updating a previous portable version the chances are due to old files still in the folder the error will not appear in the running portable version, which is probably why this loss of a function was missed during creation of this snap. |
I think this issue should be closed, as it doesn't affect NVDA itself, but external components. I think a PSA is in order on some forum, though. Just my thoughts. |
Hi, thanks for reminding me about a PSA for this. I’ll make a note to remind the add-ons community regarding this in November, and will revisit win32api in January when I plan to remove that dependency completely from the source code. Thanks.
From: fisher729 [mailto:notifications@github.com]
Sent: Monday, October 16, 2017 10:25 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] Removing NVDA Service also removed win32api, which cause problems for some add-ons (#7642)
I think this issue should be closed, as it doesn't affect NVDA itself, but external components. I think a PSA is in order on some forum, though. Just my thoughts.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#7642 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkEGYdfItutu8SRDn0QzW64s26c2lks5ss5GBgaJpZM4PsWBr> .
|
I think there should at least be a transision period for new add-ons to be updated. 2018.1 is ok for that, but I belief at least 2017.4 should still contain this dependency. |
Is this even a big module? I ask because this and win32con are extremely useful for addons, and removing this might hinder some addon development quite a lot. I would rather not see ten different versions of win32api in 10 different addons if we can stop it. |
I do agree with this, but wonder if it is actually going to go away in the
near future if the new version of Python is used.
The person who fixed golden cursor presumably put it in the main folder of
the add on.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
|
PPS...What should have happened is that just parts of the service now not
needed for XP or Vista were removed instead.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
|
As I am understanding this issue correctly, it was reproduced in Windows XP or Vista. Can you reproduce it in Windows 7 or higher? I am using Golden Cursor and am not able to reproduce it on Windows 8.1 or Windows 10. |
win32api is manually included nowadays, so I'm going to close this. Removing it again is a different issue IMO. |
When I installed as a portable version, but left the old user config file so the add ons etc would be loaded I got this error on running either the installer or the finished portable version.
ERROR - globalPluginHandler.listPlugins (12:03:44.404):
Error importing global plugin goldenCursor
Traceback (most recent call last):
File "globalPluginHandler.pyc", line 22, in listPlugins
File "C:\Users\Brian\AppData\Roaming\nvda\addons\goldenCursor\globalPlugins\goldenCursor.py", line 24, in
ImportError: No module named win32api
Seems to be rather a vital omission??
The text was updated successfully, but these errors were encountered: