Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading by sentence is broken in MS Outlook and Word #9254

Closed
andrew-l-d opened this issue Feb 8, 2019 · 11 comments · Fixed by #12874
Closed

Reading by sentence is broken in MS Outlook and Word #9254

andrew-l-d opened this issue Feb 8, 2019 · 11 comments · Fixed by #12874
Assignees
Labels
api/uia Feature or bug requires an understanding of UIA component/UIA-ms-office Specific to UIA used in MS office applications.
Milestone

Comments

@andrew-l-d
Copy link

In both the current and previous alpha snapshots, reading previous and next sentence with alt-up arrow and alt-down arrow respectively in both Outlook and Word 365 does not work. This is regardless of whether Sentence Nav is installed. With Input Help turned on, "Move to previous sentence" and "Move to next sentence" are reported. However, pressing either combination out of help mode does nothing.
I am running the alphas as portable versions on Windows 10 April 2018 and tried with both eSpeak and Windows one core voices.

Andrew

@LeonarddeR
Copy link
Collaborator

I can confirm this for Word 2016, but only when the experimental UIA support is enabled. Could you please check the state of this setting in NVDA's advanced settings and report back your result?
Also, it would be greatly appreciated if you could update your initial description according to the issue template.

@andrew-l-d
Copy link
Author

Steps to reproduce:

Open either a document in Word or an email in Outlook
Press alt-up arrow to read previous sentence or alt-down arrow to read next sentence

Actual behavior:

Nothing is presented by the screen reader

Expected behavior:

Previous or next sentence respectively should be presented

System configuration

NVDA installed/portable/running from source:

Portable

NVDA version:

nvda_snapshot_alpha-16691,10590c87, nvda_snapshot_alpha-16732,03977ad4.exe and nvda_snapshot_alpha-16733,1a45aebb.

Windows version:

Windows 10 April 2018

Name and version of other software in use when reproducing the issue:

MS Word and Outlook - MS Office 365

Other information about your system:

The NVDA Use UI Automation to access Microsoft Word document controls when available checked
Problem does not occur if Use UI Automation to access Microsoft Word document controls when available is unchecked

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes, problem does not occur with 2018.4.1 and earlier
###Apologies
Slapped wrist severely for not following template. As Leonard detected, the problem only occurs when UA Automation is used. Log file does not seem to show anything relevant.

Andrew

@LeonarddeR
Copy link
Collaborator

@andrew-l-d: Can you still reproduce this?

@andrew-l-d
Copy link
Author

Yes, I can still reproduce the issue with NVDA 2019.2.1. When "Use UI Automation to access Microsoft Word document controls when available" is checked, reading by Sentence in MS Word and Outlook 365 still does not work.
Andrew

@Adriani90 Adriani90 added api/uia Feature or bug requires an understanding of UIA component/UIA-ms-office Specific to UIA used in MS office applications. labels May 14, 2020
@andrew-l-d
Copy link
Author

Using nvda_snapshot_alpha-23809,5f9750de navigating by sentence is not possible in MS Word or Outlook due to UI automation being the only option. I have contacted the author of SentenceNav, whose current workload does not allow him to investigate for some time. As I have argued in #8518, could navigating by sentence please be a core component of NVDA. It is the only screen reader I am aware of that lacks the facility natively and it is an extremely important one.
I tried using Word's ctrl+shift+pageup/down to move by sentence. NVDA does not present the new information.

@seanbudd seanbudd changed the title Reading by sentence appears to be broken in alpha 16691,10590c87 and 16732,03977ad4 Reading by sentence is broken in MS Outlook and Word Sep 23, 2021
@seanbudd seanbudd added this to the 2021.3 milestone Sep 23, 2021
@michaelDCurran
Copy link
Member

UI Automation currently has no means of moving by sentence, though I believe this is planned via UI Automation Custom Patterns in MS Word. I have no timeline from Microsoft yet on when this will be available for NVDA to consume.
Until then, the question is whether this limitation is enough to hold back switching to UIA by default in MS Word for recent Office builds... waying that against the significant performance advantages of UIA.

@josephsl
Copy link
Collaborator

josephsl commented Sep 23, 2021 via email

@michaelDCurran
Copy link
Member

We may be able to allow a fallback to the object model for this specific feature if it is available, at least until UIA can expose this. I'll look into this.

@LeonarddeR
Copy link
Collaborator

I think we should make UIA in Word opt out when it is the default, e.g. have a similar combo box in settings as is used for UIA in Chromium.

@CyrilleB79
Copy link
Collaborator

CyrilleB79 commented Sep 23, 2021

If it is not known when MS will support sentence navigation in UIA documents, an alternative is to prioritize and implement #8518 in the meantime.

@andrew-l-d
Copy link
Author

I strongly agree with Cyrille's comment, even without the UIA issue. Reading by sentence should not be restricted to MS Office products.

michaelDCurran added a commit that referenced this issue Oct 1, 2021
… when available (#12874)

Fixes #9254

Summary of the issue:
In the past, NVDA has had the functionality to move by sentence in MS word (alt+downArrow and alt+upArrow). This functionality used the MS Word object model.
With the switch to using UI automation to access MS Word, move by sentence was lost, as MS Word's UI automation implementation provides no concept of a sentence unit.

Description of how this pull request fixes the issue:
This pr provides an implementation of moving by sentence for MS Word with UIA by falling back to the MS word object model for this specific feature, if the object model is available.
This therefore will work in MS Word and Outlook, but not in Windows Mail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/uia Feature or bug requires an understanding of UIA component/UIA-ms-office Specific to UIA used in MS office applications.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants