Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable caret events in all terminal programs #10118

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Disable caret events in all terminal programs #10118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions source/NVDAObjects/UIA/winConsoleUIA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,6 @@ def _get_TextInfo(self):
bounds review to the visible text."""
return consoleUIATextInfo

def _get_caretMovementDetectionUsesEvents(self):
"""Using caret events in consoles sometimes causes the last character of the
prompt to be read when quickly deleting text."""
return False

def _getTextLines(self):
# Filter out extraneous empty lines from UIA
return (
Expand Down
5 changes: 5 additions & 0 deletions source/NVDAObjects/behaviors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,11 @@ def event_loseFocus(self):
super(Terminal, self).event_loseFocus()
self.stopMonitoring()

def _get_caretMovementDetectionUsesEvents(self):
"""Using caret events in consoles sometimes causes the last character of the
prompt to be read when quickly deleting text."""
return False


class KeyboardHandlerBasedTypedCharSupport(Terminal):
"""A Terminal object that also provides typed character support for
Expand Down
5 changes: 0 additions & 5 deletions source/NVDAObjects/window/winConsole.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,6 @@ def reconnect():
self.startMonitoring()
core.callLater(200,reconnect)

def _get_caretMovementDetectionUsesEvents(self):
"""Using caret events in consoles sometimes causes the last character of the
prompt to be read when quickly deleting text."""
return False

@script(gestures=[
"kb:enter",
"kb:numpadEnter",
Expand Down