Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send typedCharacter events for Braille when using ToUnicodeEx #10570

Merged
merged 4 commits into from
Dec 3, 2019

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Dec 3, 2019

Link to issue number:

Closes #10569.

Summary of the issue:

The toUnicodeEx approach of typed character detection doesn't work for Braille keyboards.

Description of how this pull request fixes the issue:

Manually sends typed character events to objects using toUnicodeEx if focused. We must send all keys after they are typed to avoid unintentionally speaking passwords in Windows Console. A new keyboardHandler.shouldUseToUnicodeEx function has been added for this detection.

Testing performed:

Tested that typed characters are reported from a 5th-generation Freedom Scientific Focus keyboard, and that password reporting works as expected.

Known issues with pull request:

None.

Change log entry:

== Bug fixes ==

@codeofdusk
Copy link
Contributor Author

Cc @LeonarddeR @michaelDCurran

source/brailleInput.py Outdated Show resolved Hide resolved
@codeofdusk codeofdusk changed the title Windows Console: fix "speak typed characters" for Braille input Send typedCharacter events for Braille when using ToUnicodeEx Dec 3, 2019
@AppVeyorBot
Copy link

PR introduces Flake8 errors 😲

See test results for Failed build of commit 3e6b3e27bd

@AppVeyorBot
Copy link

PR introduces Flake8 errors 😲

See test results for Failed build of commit b56a23096e

@michaelDCurran michaelDCurran merged commit e6bf229 into nvaccess:master Dec 3, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Dec 3, 2019
michaelDCurran added a commit that referenced this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard handler/ToUnicodeEx: typed characters from Braille displays not reported
4 participants