-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for Windows 10 Version 2004 (May 2020 Update/build 19041) #10922
Conversation
This comment has been minimized.
This comment has been minimized.
Hi, COM interfaces/UIA module will not be updated, as doing so causes hundreds of Flake8 issues to show up, as this Python module isn't generated by NVDA but rather by comtypes.client. Thanks. |
Is the marketing name for 21H1 not 2004? I thought 21H1 was the codename... |
Hi, Nope - Microsoft usually releases a separate marketing name that will be used to advertise the new feature update to the public. In short, Version 2004 is known by different names depending on who you ask when:
Whenever I talk about Windows Insider features, I usually follow Windows Insider codename (20H1) or the build where a feature made its debut or a change was made. Once the releae ID is revealed will I start using YYMM. Hope this clarifies a lot. |
Possibly blocked by #10964 to avoid possible conflicts. |
How so? This PR is presumably intended for 2020.2 where #10964 is intended for immediately after (2020.3). |
Hi, because of Windows 10 version map – this PR adds 2004 whereas #10964 adds 2103. Also, this PR will not be ready for review until Version 2004 goes out to semi-annual channel (SAC). Thanks.
|
Hi, Update: sources say Version 2004 will be released in late May. Nevertheless, I'll make it an official PR as soon as Windows 10 SDK build 19041 is released to everyone (not just Insiders), as that's the one remaining thing to be done (documenting it). Thanks. |
In version 2004, UI Automation Core adds annotation sensitive type.
This reverts commit cba5ca0, caused by hundreds of Flake8 errors with UIA COM interfaces file (AnnotationTypeSensitive flag will not be in use until Flake8 issues are resolved).
… no longer complain about COM interface changes.
Hi, And now, ready for official pull request review. Thanks. |
I think this deserves a place in 2020.2. |
hi @josephsl |
@josephsl (or others) could you update the description with why you feel this is important to include in 2020.2? What does this give us? |
Hi, Done. Thanks. |
Link to issue number:
None
Summary of the issue:
Introduce support for Windows 10 Version 2004 (build 19041).
Description of how this pull request fixes the issue:
In isWin10 function/map, recognize build 19041 as Version 2004, along with updating COM interfaces/UIA module to 10.0.19041, which introduces AnnotationTypeSensitive (60024). Also updated readme to point to Windows SDK version 10.0.19041.
Testing performed:
Tested with source copy of NVDA running on Windows 10 build 19041.172.
Known issues with pull request:
None
Change log entry:
None needed.
Special commit message and 2020.2 inclusion:
The commit message may need to mention "May 2020 Update". As for 2020.2, although this change is minimal, it is consistent with Windows 10 release updates and how NVDA responded to these in the past (take October 2018 Update and changes such as dialog reading, which was included in a 2018.x release).
Thanks.