Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for Windows 10 Version 2004 (May 2020 Update/build 19041) #10922

Merged
merged 6 commits into from
Jun 11, 2020

Conversation

josephsl
Copy link
Collaborator

@josephsl josephsl commented Mar 31, 2020

Link to issue number:

None

Summary of the issue:

Introduce support for Windows 10 Version 2004 (build 19041).

Description of how this pull request fixes the issue:

In isWin10 function/map, recognize build 19041 as Version 2004, along with updating COM interfaces/UIA module to 10.0.19041, which introduces AnnotationTypeSensitive (60024). Also updated readme to point to Windows SDK version 10.0.19041.

Testing performed:

Tested with source copy of NVDA running on Windows 10 build 19041.172.

Known issues with pull request:

None

Change log entry:

None needed.

Special commit message and 2020.2 inclusion:

The commit message may need to mention "May 2020 Update". As for 2020.2, although this change is minimal, it is consistent with Windows 10 release updates and how NVDA responded to these in the past (take October 2018 Update and changes such as dialog reading, which was included in a 2018.x release).

Thanks.

@AppVeyorBot

This comment has been minimized.

@josephsl
Copy link
Collaborator Author

Hi,

COM interfaces/UIA module will not be updated, as doing so causes hundreds of Flake8 issues to show up, as this Python module isn't generated by NVDA but rather by comtypes.client.

Thanks.

@codeofdusk
Copy link
Contributor

Once release date and marketing name for 20H1 comes out, the commit message should mention both (along with build number).

Is the marketing name for 21H1 not 2004? I thought 21H1 was the codename...

@josephsl
Copy link
Collaborator Author

Hi,

Nope - Microsoft usually releases a separate marketing name that will be used to advertise the new feature update to the public.

In short, Version 2004 is known by different names depending on who you ask when:

  • Vibranium: internal codename for Microsoft Azure release that powers internals of Version 2004. In late 2019, in preparation for Version 2004 RTM, vb_rlease branch was forked from rs_prerelease branch, and Vibranium was finalized in December 2019. The bits the Azure team have been working on became a significant part of Version 2004, as internal release schedule between Windows and Azure are synchronized. Internally, Microsoft Azure team uses chemical element names for codenames. Version 1903 was internally codenamed Vanadium by Azure team, the next element is Chromium, but it became the codebase for Edge 79 and later. The next release (likely 20H2 or 21H1) is internally codenamed "Manganese" by Azure team.
  • 20H1: this is the codename used by Windows Insider Program participants to denote early builds of the next feature update, and is the codename that is widely used to refer to Version 2004 until the next hing happened.
  • 2004: what we call "2004" is actually a release ID - it isn't called 2003 because Windows server 2003 already took that name, hence 2004 became the release ID.
  • A marketing name: eventually Microsoft will reveal a public marketing name to refer to Version 2004. The most likely marketing name is "May 2020 Update" unless Microsoft releases build 19041 to release preview ring Insiders and to the public in April, in which case Microsoft may call it "April 2020 Update".

Whenever I talk about Windows Insider features, I usually follow Windows Insider codename (20H1) or the build where a feature made its debut or a change was made. Once the releae ID is revealed will I start using YYMM.

Hope this clarifies a lot.

@josephsl
Copy link
Collaborator Author

josephsl commented Apr 8, 2020

Possibly blocked by #10964 to avoid possible conflicts.

@codeofdusk
Copy link
Contributor

How so? This PR is presumably intended for 2020.2 where #10964 is intended for immediately after (2020.3).

@josephsl
Copy link
Collaborator Author

josephsl commented Apr 9, 2020 via email

@josephsl josephsl changed the title Introduce support for Windows 10 Version 2004 (build 19041) Introduce support for Windows 10 Version 2004 (May 2020 Update/build 19041) Apr 12, 2020
@josephsl
Copy link
Collaborator Author

josephsl commented May 6, 2020

Hi,

Update: sources say Version 2004 will be released in late May. Nevertheless, I'll make it an official PR as soon as Windows 10 SDK build 19041 is released to everyone (not just Insiders), as that's the one remaining thing to be done (documenting it).

Thanks.

josephsl added 5 commits May 12, 2020 10:40
In version 2004, UI Automation Core adds annotation sensitive type.
This reverts commit cba5ca0, caused by hundreds of Flake8 errors with UIA COM interfaces file (AnnotationTypeSensitive flag will not be in use until Flake8 issues are resolved).
… no longer complain about COM interface changes.
@josephsl josephsl marked this pull request as ready for review May 12, 2020 17:41
@josephsl
Copy link
Collaborator Author

Hi,

And now, ready for official pull request review.

Thanks.

@LeonarddeR
Copy link
Collaborator

I think this deserves a place in 2020.2.

@codeofdusk
Copy link
Contributor

Cc @feerrenrut @michaelDCurran

@dpy013
Copy link
Contributor

dpy013 commented Jun 5, 2020

hi @josephsl
Appveyor's visual studio2019 mirror has been updated
Visual Studio 2019 image update on May 29, 2020
What’s new
Windows 10 SDK/WDK, version 2004 (10.0.19041.0)
thanks

@feerrenrut
Copy link
Contributor

@josephsl (or others) could you update the description with why you feel this is important to include in 2020.2? What does this give us?

@josephsl
Copy link
Collaborator Author

josephsl commented Jun 9, 2020

Hi,

Done. Thanks.

@feerrenrut feerrenrut merged commit b79276c into nvaccess:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants