-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify success of forward review moves by word and line #12960
Conversation
…hat the new line does in deed start after the original review cursor position. Otherwise, we have hit the bottom.
"...but simply set them to POSITION_LAST (i.e. collapsed at the very end of the document)." |
Description updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @codeofdusk - I've left some minor fixes for the comments.
Tested in affected modern providers.
Have you tested these commands in other scenarios (eg not UIA)?
was meant to be a comment not an approval
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Yes, tested in Notepad with MSAA. |
See test results for failed build of commit 3c564a6699 |
Link to issue number:
Closes #12808.
Summary of the issue:
In Microsoft Word, new builds of Windows Console, and Edgium with UIA enabled, "bottom" is not reported when moving past the end of the document in review. These providers return nonzero when moving collapsed
textInfo
s forward past the end, but simply set them to the exclusive end of the document.Description of how this pull request fixes the issue:
When moving forward by word or line, maintain the old position and verify that the new position is after the previous.
Testing strategy:
Tested in affected modern providers, notepad with MSAA, Chrome with IA2, and the MS Word object model.
Known issues with pull request:
None known.
Change log entries:
== Bug Fixes ==
Code Review Checklist: