Report aria-haspopup dialog/grid/list/tree in Firefox and Chrome.

[jcsteh]

Link to issue number:

Fixes #8235.

Summary of the issue:

NVDA reports "sub menu" for all values of aria-haspopup, which is misleading at best.

Description of user facing changes

In Mozilla Firefox and Google Chrome, NVDA now reports when a control opens a dialog, grid, list or tree if the author has specified this using aria-haspopup.

Description of development approach

1. Created new states for HASPOPUP_DIALOG, GRID, LIST and TREE. The general HASPOPUP state is still used for menus.
2. Mapped the ARIA string values to states.
3. Modified both the IA2Web NVDAObject and the Gecko_ia2 vbuf to expose these new states based on the haspopup object attribute.

Testing strategy:

Tested with the test case in #8235. The correct message - "opens dialog", etc. - is reported when tabbing in focus mode, tabbing in browse mode, moving by line in browse mode and quick navigating in browse mode.

Known issues with pull request:

None.

Change log entries:

New features
In Mozilla Firefox and Google Chrome, NVDA now reports when a control opens a dialog, grid, list or tree if the author has specified this using aria-haspopup.

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.