Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use UIA caret events in Windows Terminal (#16873)" #17048

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Revert "Use UIA caret events in Windows Terminal (#16873)" #17048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8375b03
Revert "Use UIA caret events in Windows Terminal (#16873)"
codeofdusk Aug 23, 2024
766d572
Merge branch 'beta' into revert-wt-caret-events-2024
seanbudd Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions source/NVDAObjects/UIA/winConsoleUIA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,10 +450,6 @@ def event_UIA_notification(self, **kwargs):
"Block notification events when diffing to prevent double reporting."
log.debugWarning(f"Notification event blocked to avoid double-report: {kwargs}")

def _get_caretMovementDetectionUsesEvents(self) -> bool:
"Windows Terminal has a good implementation of caret move detection."
return True


class _NotificationsBasedWinTerminalUIA(UIA):
"""
Expand Down