Update liblouis to 3.31 #17080
Update liblouis to 3.31 #17080
Conversation
|
Cc @codeofdusk who did the liblouis updates in the past. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
seanbudd
added
the
conceptApproved
|
@codeofdusk @LeonarddeR - we don't introduce risky changes, new features or dependency updates in the beta cycle unless they are important bug fixes.
Generally we would expect these updates to happen early in the alpha cycle to ensure there is maximum testing before we release. |
|
This PR does include an important bug fix:
|
|
Is this a bug fix for a recent regression? Most liblouis releases contain some level of bug fixes, we would still generally hold back from a late inclusion as regressions may be introduced with these bug fixes. If we merge this late, and there's regressions within the bug fixes, we get caught in a bad cycle where we have to revert the update and extend the release cycle. Or even worse, we ship with regressions. If this is merged early in a release cycle, it can get adequate testing, and we can ship it with greater certainty that is doesn't introduce any regressions. |
|
Per liblouis/liblouis#1574 (comment) this is new as of Liblouis 3.30 (NVDA 2024.3). |
|
Given @LeonarddeR stepping away (and inability to respond to mentions) I'm happy to take this over. |
|
@seanbudd This PR is now ready for review against beta, but since I don't own it, I can't change its status. |
WalkthroughThe updates include an upgrade to the LibLouis Braille translator to version 3.31.0, introducing new Braille tables and refining existing descriptions. The eSpeak NG component has also been updated to version 1.52-dev, adding support for additional languages and enhancing command line options. Documentation has been revised to reflect these changes, ensuring clarity on the updated functionalities and features. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (6)
source/brailleTables.py (1)
633-635: New Thai grade 1 braille table added.The addition of the Thai grade 1 table is a valuable expansion of the braille options for Thai users. The settings (input=False, contracted=True) are appropriate for a grade 1 table.
Consider adjusting the comment formatting for consistency:
-# Translators: The name of a braille table displayed in the -# braille settings dialog. +# Translators: The name of a braille table displayed in the braille settings dialog. addTable("th-g1.utb", _("Thai grade 1"), input=False, contracted=True)This change aligns with the single-line comment style used for other table entries.
user_docs/en/changes.md (5)
Line range hint
6-10: Consider adding more context to the first bullet point.The first bullet point about moving forward and backward by sentence in Microsoft Word and Outlook is clear, but it might be helpful to mention what the previous behavior was for comparison.
Line range hint
15-18: Consider clarifying the "multiple press gesture" setting.The explanation of the new setting for configuring the timeout for multiple press gestures is clear, but it might be helpful to provide an example of when this would be used.
Line range hint
26-31: Consider adding more context about the experimental option.The explanation of the new experimental option for browse mode focus behavior is clear, but it might be helpful to provide more context about why a user might want to enable this option.
Line range hint
36-41: Consider providing examples for some of these new commands.The new commands for showing symbol replacement and context information are clearly explained, but providing examples of when these might be useful could enhance user understanding.
46-47: Consider expanding on the Python Console enhancement.The new feature for the Python Console is briefly mentioned. It might be helpful to provide a bit more detail about how this improves usability for developers.
See test results for failed build of commit e59d862e1a |
Thanks @codeofdusk |
|
From
|
|
If it is only back translation, then I guess it is of slightly less importance. Honestly I thought that it caused issues with forward translation. |
|
It causes issues with forward translation as well. The prefix for digits ( |
Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>
|
@SaschaCowley Please re-target this PR to the |
Preliminary note
Liblouis 3.31 is to be released on the 2nd of September
Link to issue number:
None
Summary of the issue:
Liblouis 3.31 is to be released soon. AMong new tables, this release contains a bug fix for Spanish causing digits to be presented incorrectly, see liblouis/liblouis#1624. CC @jmdaweb. Hence this pr is filed against beta.In my humble opinion, we are still early enough in the beta cycle to warrant this update.
Description of user facing changes
Update to Liblouis 3.31, adding new tables as mentioned in the changelog.
Description of development approach
Update the submodule, added and updated definitions in
brailleTables.pyTesting strategy:
Running NVDA< ensured that the new and changed tables work.
Known issues with pull request:
None known
Code Review Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation