Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 11 clipboard history: NVDA no longer announces history items when closing clipboard history interface #17361

Merged
merged 4 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -430,3 +430,14 @@ def chooseNVDAObjectOverlayClasses(self, obj, clsList):
elif obj.UIAAutomationId == "Windows.Shell.InputApp.FloatingSuggestionUI.DelegationTextBox":
clsList.remove(EditableTextWithAutoSelectDetection)
clsList.remove(XamlEditableText)

def event_NVDAObject_init(self, obj: NVDAObject) -> None:
# #17308: recent Windows 11 builds raise live region change event when clipboard history closes,
# causing NVDA to report data item text such as clipboard history entries.
# Therefore, tell NVDA to veto this event at the object level, otherwise focus change handling breaks
# due to live region change event being queued.
if obj.role == controlTypes.Role.DATAITEM and obj.parent.role in (
controlTypes.Role.TABLEROW, # Clipboard history item
controlTypes.Role.LIST, # Clipboard history item actions list
):
obj._shouldAllowUIALiveRegionChangeEvent = False
1 change: 1 addition & 0 deletions user_docs/en/changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ To use this feature, "allow NVDA to control the volume of other applications" mu
* After reporting a normalized character, NVDA no longer incorrectly reports subsequent characters as normalized. (#17286, @LeonarddeR)
* Composite characters (such as é) are now reported correctly. (#17295, @LeonarddeR)
* In Word or Outlook, when using legacy object model, the command to report the destination URL of a link does not report any longer "Not a link" when there is one to report. (#17292, @CyrilleB79)
* NVDA will no longer announce Windows 11 clipboard history entries when closing the window while items are present. (#17308, @josephsl)
* If the plugins are reloaded while a browseable message is opened, NVDA will no longer fail to report subsequent focus moves. (#17323, @CyrilleB79)

### Changes for Developers
Expand Down