Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the link for "Build (for testing PR)" in appVeyor message #17510

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Dec 12, 2024

Link to issue number:

Probably fix-up of #17214.
Follow-up of #17249.

Summary of the issue:

When an appVeyor test failure message is issued, the build link in this message is on l10nUtil.exe rather than on nvda_snapshot_xxxx.exe.

Description of user facing changes

The NVDA snapshot executable will be again downloadable from appVeyor messages.

Description of development approach

Refine the filtering to find the snapshot executable on "nvda_.exe" rather than on ".exe", as done in the deploy script in #17249 in appVeyor script.

Testing strategy:

Introduce an error in unit tests to trigger the message and check the result: see #17510 (comment).

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@AppVeyorBot
Copy link

See test results for failed build of commit 34e60e7017

@CyrilleB79 CyrilleB79 marked this pull request as ready for review December 12, 2024 14:19
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner December 12, 2024 14:19
@CyrilleB79 CyrilleB79 requested a review from seanbudd December 12, 2024 14:19
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit edf6811 into nvaccess:master Dec 12, 2024
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Dec 12, 2024
@CyrilleB79 CyrilleB79 deleted the exeLink branch December 13, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants