Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximize seems to be broken #122

Closed
eddyekofo94 opened this issue Aug 22, 2023 · 3 comments · Fixed by #127
Closed

Maximize seems to be broken #122

eddyekofo94 opened this issue Aug 22, 2023 · 3 comments · Fixed by #127
Labels
bug Something isn't working

Comments

@eddyekofo94
Copy link

function M.maximise()
    local width, height = vim.o.columns, vim.o.lines

    local win = vim.api.nvim_get_current_win()
    local view = vim.fn.winsaveview()
    vim.api.nvim_win_set_width(win, width)
    vim.api.nvim_win_set_height(win, height)
    vim.api.nvim_win_call(function()
        vim.fn.winrestview(view)
    end)
end

This method since the last updated it is broken.
Locally I fixed it by passing the win variable like this

vim.api.nvim_win_call(win, function()
        vim.fn.winrestview(view)
 end)
@cryptomilk cryptomilk added the bug Something isn't working label Aug 24, 2023
@cryptomilk
Copy link
Collaborator

@willothy FYI ;-)

@willothy
Copy link
Collaborator

Oops, that must have happened while resolving a conflict during rebase while I was cleaning up the commits in that PR. I'll send in a PR fixing this tonight!

@eddyekofo94
Copy link
Author

There seems to be a few things not working quite right since the last refactoring. Is there tests to check nothing breaks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants