-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unnecessary uses of nvim_win_call #127
Conversation
Thanks for your contribution! Remember: Untested code is broken code :-) |
Usually I'd agree, but this is a tiny fix that pretty much just removes a line that was previously broken, so not sure what test I'd add for this. Let me know if you have any ideas. |
Obvoiously our test didn't catch this bug someone noticed it an opened #122. So what are the steps the of the person running into this? |
Ah, gotcha, I see! I'll add a test for maximize overall. |
Thanks! :-) |
May not have time to get to that right away as I'm a bit busy this week, maybe this PR should be merged since it's a hotfix and definitely works, and I'll add the test in a followup PR in a few days? Up to you though :) |
Added tests @cryptomilk |
Awesome thanks! |
fix: remove unnecessary uses of nvim_win_call
(moving immediate autoresize to another PR as it needs test changes)
closes #122