fix: autoresize immediately on mode change #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willothy
force-pushed
the
resizer-fix-2
branch
from
7647c33
to
50eb83d
Compare
willothy
force-pushed
the
resizer-fix-2
branch
2 times, most recently
from
9e83ba7
to
bbb9006
Compare
willothy
commented
Sep 18, 2023
willothy
force-pushed
the
resizer-fix-2
branch
2 times, most recently
from
9ace770
to
a8502b9
Compare
cryptomilk
requested changes
Sep 19, 2023
When the resize goal is changed, so essentially yes. Maybe "goal change" is better wording, just want sure what to call it. |
willothy
force-pushed
the
resizer-fix-2
branch
3 times, most recently
from
39d1149
to
5c90e07
Compare
ensures that windows are properly resized immediately when the mode is changed, instead of on the next window switch.
willothy
force-pushed
the
resizer-fix-2
branch
from
5c90e07
to
d5908e7
Compare
|
Ok, cleaned up copy-pasted comments, changed the test names, and rebased on top of master. |
cryptomilk
approved these changes
Sep 19, 2023
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that windows are properly resized immediately when the mode is changed, instead of on the next window switch.
Also adds several tests for resizing behavior.