feat(test_harness): Add opts to test_harness.test_file #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROBLEM: There was no way to configure opts (such as init, minimal, etc.) for running a single file test (`test_harness.test_file(file)`). SOLUTION: Add `opts` parameter.
|
Should I also change the vim command to parse the opts string like in PlenaryBustedDirectory? |
yeah i think that would be handy |
|
I just spent some time rediscovering that PlenaryBustedFile doesn't pass opts. Any chance this could get merged? Edit: actually, i see a bit more is involve in making this work from the command line. I'll submit my own PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROBLEM:
There was no way to configure opts (such as init, minimal, etc.) for
running a single file test (
test_harness.test_file(file)).SOLUTION:
Add
optsparameter.