-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests names with backticks are either ignored or always produce an error #46
Comments
Looking at the generated command from the Neotest output, it looks like the entire
|
This seems to have been fixed at some point — I made a PR (#117) with regression tests just to be sure. |
@conermurphy #112 seems to fix tests that use backticks instead of single- or double-quotes for a JavaScript test string — e.g. |
Ah that makes sense then @loqusion I did notice that the backticks in strings was working when I did #112 but they must have been fixed by the earlier PR before I did that one. Also unrelated but I assume you have the tests running locally to make that PR? If so, would you be able to help with #114 at all? I'm keen to write tests when I contribute but can't get them running. |
I actually can't get the script to run either 😅 instead, I used the |
Ah okay so you just ran the jest tests in the repo using |
When there are two backticks in a test name, the test is ignored. When there is only one, the following error message is produced:
It seems that backticks are not properly escaped before being passed to the
jest
command, which causes them to be interpreted by the shell as command substitution instead of literal characters.The text was updated successfully, but these errors were encountered: