Remove ' from testNamePatterns to fix failing tests #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haydenmeade do you think this solution could break something we are not aware of ? |
|
@JaapBarnhoorn could you please rebase your change with latest |
Seems ok if it's been tested |
I have tested it for a while and did not encounter any issue so far |
mikaoelitiana
added a commit
to mikaoelitiana/neotest-jest
that referenced
this pull request
Dec 11, 2023
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #68
The suggestion done in #68 fixes my problem with Jest not finding the tests.
I'm not sure if this is a valid fix, but this works for me on Linux